Fixed conflict between wow.js and jQuery Revolution Slider #88
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Slider when the latter has a caption with the data-splitin=words or data-splitin=chars property applied.
|
OK, this makes perfect sense. Here is some reference so we have this documented why this needed to change. I'll merge this but I have to change the coffeescript file instead. Thanks @lgrandicelli. |
|
Changes converted to CoffeeScript in 75465f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using WOW.js and jQuery Revolution Slider, if the latter has a caption with the data-splitin=words or data-splitin=chars property applied, a javascript error is reported in console as follows:
Uncaught TypeError: undefined is not a function wow.js:185
WOW.WOW.doSync wow.js:185
(anonymous function) wow.js:150
MutationObserver.observe.childList
Fixed by adding "if(element.nodeType !== 1) return;".