take screenshots of correct window

[dreyks]

fixes #143

unfortunately couldn't figure out how to properly test this - base capybara driver is not capable of switching windows

[mattheworiordan]

Thanks for this contribution @dreyks, however this code is not threadsafe AFAICT. Capybara Screenshot does indeed share static variables, however unless there is a bug, the idea is that session (test) specific state is not stored at a static class level for obvious reasons (parallel tests). Would you be able to look into a way to use a test local variable instead?

[dreyks]

🤔 At first I've been thinking about that but then I saw some other places of direct writing into a static variable like this

capybara-screenshot/lib/capybara-screenshot/capybara.rb

Line 18 in cac1bee

Capybara::Screenshot.final_session_name = original_session_name

But I think I can store the offending window in the capybara session (or page) itself

[mattheworiordan]

At first I've been thinking about that but then I saw some other places of direct writing into a static variable like this

Mmm, that's not good. I'll raise an issue to fix that too down the line.

[trcarden]

@mattheworiordan and @dreyks Has this stalled out? I found myself also in a situation where it would be quite nice to the the screenshot from the new window.

[mattheworiordan]

Has this stalled out?

Yup, waiting on @dreyks to update I am afraid.

[cgunther]

@trcarden check out #287

[mattheworiordan]

Closing as superseded by #287