Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Written numbers parsing integration #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Aug 1, 2013

It's not really working yet, tests in two days and two years from yesterday at five pm are failing.

I'm not really satisfied with the replacement I've found for the .skip(), this may be the cause of the mentioned failures.

@matthewmueller
Copy link
Owner

Sweet. there seems to be some extra stuff in this PR. "midnight", some other changes. It'd be better if the written numbers PR was isolated.

@nmussy
Copy link
Contributor Author

nmussy commented Aug 1, 2013

That's not from me, I don't know why it's showing up in the diffs, maybe I made a bad branching: e3ec84df90bcc2d18776102f089542a3681ee1d5

@nmussy
Copy link
Contributor Author

nmussy commented Aug 1, 2013

No, it's actually worse than that.

The midnight diff is only showing up on dist/date.js, because I just built it again. It hasn't been made in months...

@matthewmueller
Copy link
Owner

ahh okay, that's the probably with distributions is that they always get out of date.

@nmussy
Copy link
Contributor Author

nmussy commented Aug 2, 2013

It's working now, I wasn't consuming the space in the process before.

All tests are working, except those containing two written numbers, like two years from yesterday at five pm.
I haven't figured out how to differentiate two separate numbers from one number with a bunch of junk between the words.

@nmussy
Copy link
Contributor Author

nmussy commented Aug 2, 2013

Okay, horrible idea, I don't know why it was working, but it's not clean at all.
I'm working on a fix.

@nmussy
Copy link
Contributor Author

nmussy commented Aug 5, 2013

Here is what is working and not working so far:

√ in two days
√ tonight at five
√ in five hours
√ tomorrow night at nine
  two years from yesterday at five pm
√ two years from yesterday at 5pm
√ two months from tomorrow
√ this morning at nine
  tuesday at nine am
  tuesday at nine
  at twelve thirty
  next monday at one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants