More correct http statuses in the README.md #106
Conversation
| @@ -35,10 +35,13 @@ require('isomorphic-fetch'); | |||
|
|
|||
| fetch('//offline-news-api.herokuapp.com/stories') | |||
| .then(function(response) { | |||
| if (response.status >= 400) { | |||
| if (response.status >= 200 || response.status < 400) { | |||
| return response.json(); | |||
There was a problem hiding this comment.
Not all requests with code >=200 and <400 will have valid JSON body.
There was a problem hiding this comment.
as well >=400 did not pass this requirement
There was a problem hiding this comment.
| if (response.status >= 400) { | ||
| if (response.status >= 200 || response.status < 400) { | ||
| return response.json(); | ||
|
|
|
I mean I guess it is true that the status codes between 200 and 400 would be ‘good’ … but if you are in control of your backend you would know what valid statuses it would reply with and in this case it would only ever reply with 200 if it's healthy… (In some ways it's safer to treat unexpected statuses as errors on the front end, even if they're technically valid HTTP status codes because you may want to have different behaviour) In any case if you wanted to have such a broad check for “ok” statuses I think I think I will close this without change but if you disagree please let me know. |
No description provided.