Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add german selectors #6

Merged
merged 1 commit into from
Jun 28, 2024
Merged

add german selectors #6

merged 1 commit into from
Jun 28, 2024

Conversation

aladoui
Copy link
Contributor

@aladoui aladoui commented Jun 24, 2024

🎯 Scope

🌱 Implementation

🖼️ Screenshots or video capture (optional)

🧪 How To Test


🫶 Reviewer's Companion

To ensure a successful review, please follow these guidelines:

  • Current branch is up to date with target branch.
  • Follow the team standards #code.
  • Keep it simple, sweetie (KISS). Simplify your code by removing unnecessary complexity or redundancy.
  • Don't repeat yourself (DRY). Avoid duplicating code by extracting common functionality into reusable functions or modules.
  • No private customer data is shown in code.
  • Document your code. see here.
  • Avoid unnecessary comments. Comments should only be used to explain complex or unusual code.
  • Remove unintentional logs. Logs left behind after debugging can be a security and performance risk, so be sure to remove them before committing your code.

@aladoui aladoui requested review from Karim-Sh and dancobo June 24, 2024 15:20
@aladoui aladoui merged commit 025cc48 into main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants