[MM-47629] Don't crash when a run channel has been deleted #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienTant
commented
May 29, 2024
webapp/src/components/backstage/playbook_runs/playbook_run/playbook_run.tsx
Show resolved
Hide resolved
| } | ||
| team, err := s.pluginAPI.Team.Get(channel.TeamId) | ||
| team, err := s.pluginAPI.Team.Get(playbookRun.TeamID) |
There was a problem hiding this comment.
use the run teamID because the channel might not exist
| @@ -1266,11 +1266,12 @@ func (s *PlaybookRunServiceImpl) GetPlaybookRunMetadata(playbookRunID string) (* | |||
| // Get main channel details | |||
| channel, err := s.pluginAPI.Channel.Get(playbookRun.ChannelID) | |||
| if err != nil { | |||
| return nil, errors.Wrapf(err, "failed to retrieve channel id '%s'", playbookRun.ChannelID) | |||
| s.pluginAPI.Log.Warn("failed to retrieve channel id", "channel_id", playbookRun.ChannelID) | |||
There was a problem hiding this comment.
I guess this is the main core change: considering that a missing channel is not a big deal and we can continue the process without it.
| <LockOutlineIcon size={20}/> {formatMessage({defaultMessage: 'Private'})} | ||
| </ItemDisabledContent> | ||
| } | ||
| <ChannelRow |
There was a problem hiding this comment.
I moved the channel row to it's own component because we started to have a lot of conditions.
JulienTant
added
the
Setup Cloud Test Server
lieut-data
approved these changes
May 29, 2024
webapp/src/components/backstage/playbook_runs/playbook_run/playbook_run.tsx
Show resolved
Hide resolved
calebroseland
approved these changes
May 31, 2024
webapp/src/components/backstage/playbook_runs/playbook_run/rhs_info_overview.tsx
Outdated
Show resolved
Hide resolved
…_info_overview.tsx Co-authored-by: Caleb Roseland <[email protected]>
mattermost-build
removed
the
Setup Cloud Test Server
|
Test server destroyed |
1 similar comment
|
Test server destroyed |
|
Test server creation failed. Review the error details here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows for a run page to be visited even if the associated channel has been removed.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47629
Checklist
- [ ] Telemetry updated- [ ] Gated by experimental feature flag