Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Optimize contracts build #715

Merged
merged 3 commits into from
Jan 2, 2024
Merged

ci: Optimize contracts build #715

merged 3 commits into from
Jan 2, 2024

Conversation

otani88
Copy link
Contributor

@otani88 otani88 commented Dec 20, 2023 •
edited
Loading

What ❔

Moves contracts build to separate job and reuses them as an artifact in further build jobs

Why ❔

To decrease CI build time

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@otani88 otani88 marked this pull request as ready for review December 21, 2023 09:53
@otani88 otani88 requested a review from a team as a code owner December 21, 2023 09:53
@otani88 otani88 marked this pull request as draft December 22, 2023 11:22
@otani88 otani88 force-pushed the add_multiarch_support branch from 9bc69d7 to fda3053 Compare January 1, 2024 16:46
@otani88 otani88 changed the title ci: multiarch pipeline ci: optimize build time Jan 2, 2024
@otani88 otani88 marked this pull request as ready for review January 2, 2024 09:19
@hatemosphere hatemosphere changed the title ci: optimize build time ci: Optimize contracts build Jan 2, 2024
@hatemosphere hatemosphere added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 2ff09b2 Jan 2, 2024
@hatemosphere hatemosphere deleted the add_multiarch_support branch January 2, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik yorik left review comments

@Deniallugo Deniallugo Deniallugo approved these changes

@hatemosphere hatemosphere hatemosphere approved these changes

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otani88 @yorik @Deniallugo @hatemosphere