-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a flag for stage1->stage2 validium migration #3562
base: main
Are you sure you want to change the base?
Changes from 9 commits
0d5861c
54543bc
14df697
87deeb0
58da20b
4123275
7cef084
7b0b65c
ddd22b2
c9fb977
673ed1b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TABLE data_availability DROP COLUMN l2_da_validator_address IF EXISTS ; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TABLE data_availability ADD COLUMN l2_da_validator_address BYTEA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Is there a difference with defining
inclusion_verification_transition_enabled: bool
and slapping#[serde(default)]
on it / slightly changing the Protobuf conversion logic? From the type perspective, it looks easier, and in the new config system (that I hope we will use eventually 🙃), a simpler type would mean better auto-generated docs / validations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly did it like that to keep in line with the other fields in this config, IMO it would be even worse if some fields were
Optional
with a getter and the others had#[serde(default)]
I would even consider adding
#[serde(default)]
to all of them and removingOptional
, but maybe it makes sense to do it as a part of a migration to the new config system