refactor: move Cargo.toml from root to core workspace #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbaliasnikov
force-pushed
the
aba-move-cargo-to-core
branch
3 times, most recently
from
97ee4b6 to
a5161b3
Compare
antonbaliasnikov
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88,
iluwaa and
popzxc
antonbaliasnikov
force-pushed
the
aba-move-cargo-to-core
branch
2 times, most recently
from
2ab2a68 to
b4926e6
Compare
|
@popzxc , can you, please, merge when it's ok? It looks like I'm not authorized to merge here. |
|
@antonbaliasnikov looks like there is a merge conflict now 🥲 |
antonbaliasnikov
force-pushed
the
aba-move-cargo-to-core
branch
from
b4926e6 to
caccdf4
Compare
@popzxc , rebased my changes and fixed a bug in |
popzxc
approved these changes
Jan 16, 2025
artmakh
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Move
Cargo.tomlfrom repository root tocoreworkspace.Why ❔
It is mandatory for proper separation of workspaces and setting up a
release-pleaseCI that requires all files of a component to be inside the component directory.CI failures
Currently, the following tests are failing:
protobuf_compatibility- the workflow is using base version and will be fixed with the next PRs after merge tomain.Checklist
zkstack dev fmtandzkstack dev lint.