Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract-verifier): Support Solidity contracts with EVM bytecode in contract verifier #3225

Merged
merged 19 commits into from
Nov 6, 2024
Merged

feat(contract-verifier): Support Solidity contracts with EVM bytecode in contract verifier #3225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b454b82
Sketch deployed contract query
slowli Nov 1, 2024
034f9c6
Use `DalResult`s in verification DAL
slowli Nov 1, 2024
901dd51
Test `get_contract_info_for_verification`
slowli Nov 1, 2024
d75c796
Refactor compiler inputs
slowli Nov 1, 2024
8d37ec7
Sketch standalone `solc` compiler support
slowli Nov 1, 2024
2643cef
Sketch deployed bytecodes comparison
slowli Nov 1, 2024
51df909
Test standalone `solc` compilation
slowli Nov 1, 2024
af1ca41
Test EVM bytecode verification
slowli Nov 4, 2024
faffe03
Verify creation code / args for EVM bytecodes
slowli Nov 4, 2024
ad3725f
Test more verification errors
slowli Nov 4, 2024
1fac117
Update lockfiles
slowli Nov 4, 2024
2e2f008
Test creation bytecode mismatch
slowli Nov 4, 2024
2e75e36
Improve string ownership for compiler versions
slowli Nov 4, 2024
c17db75
Improve compiler path resolution
slowli Nov 4, 2024
70915fb
Simplify resolver initialization in tests
slowli Nov 4, 2024
163ba0a
Brush up code
slowli Nov 4, 2024
9318e12
Revert `contracts` submodule changes
slowli Nov 4, 2024
84c3838
Use `&'static str` for another error variant
slowli Nov 4, 2024
31b8b30
Sanity-check compiler type
slowli Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use DalResults in verification DAL
  • Loading branch information
@slowli
slowli committed Nov 4, 2024
commit 034f9c66229fbbf19fd607e16dbbb12b822aba92
8 changes: 4 additions & 4 deletions core/lib/contract_verifier/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ impl ContractVerifier {
};
storage
.contract_verification_dal()
.save_verification_error(request_id, error_message, compilation_errors, None)
.save_verification_error(request_id, &error_message, &compilation_errors, None)
.await?;
tracing::info!("Request with id = {request_id} was failed");
}
Expand Down Expand Up @@ -547,9 +547,9 @@ impl JobProcessor for ContractVerifier {
.contract_verification_dal()
.save_verification_error(
job_id,
"Internal error".to_string(),
serde_json::Value::Array(Vec::new()),
Some(error),
"Internal error",
&serde_json::Value::Array(Vec::new()),
Some(&error),
)
.await
.unwrap();
Expand Down
Loading