Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): Allow creating owned Postgres connections #2654

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Aug 14, 2024

What ❔

  • Changes Connection so that it has 'static lifetime if created from a pool (i.e., when it is non-transactional).
  • Simplifies ReadStorageFactory and MainBatchExecutor accordingly.

Why ❔

Reduces complexity. 'static connections can be sent to a Tokio task etc., meaning improved DevEx.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli marked this pull request as ready for review August 14, 2024 12:10
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@slowli slowli added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 47a082b Aug 16, 2024
51 checks passed
@slowli slowli deleted the aov-pla-1014-allow-creating-owned-postgres-connections branch August 16, 2024 07:38
github-merge-queue bot pushed a commit that referenced this pull request Aug 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.19.0](core-v24.18.0...core-v24.19.0)
(2024-08-21)


### Features

* **db:** Allow creating owned Postgres connections
([#2654](#2654))
([47a082b](47a082b))
* **eth-sender:** add option to pause aggregator for gateway migration
([#2644](#2644))
([56d8ee8](56d8ee8))
* **eth-sender:** added chain_id column to eth_txs + support for gateway
in tx_aggregator
([#2685](#2685))
([97aa6fb](97aa6fb))
* **eth-sender:** gateway support for eth tx manager
([#2593](#2593))
([25aff59](25aff59))
* **prover_cli:** Add test for status, l1 and config commands.
([#2263](#2263))
([6a2e3b0](6a2e3b0))
* **prover_cli:** Stuck status
([#2441](#2441))
([232a817](232a817))
* **prover:** Add ProverJobMonitor
([#2666](#2666))
([e22cfb6](e22cfb6))
* **prover:** parallelized memory queues simulation in BWG
([#2652](#2652))
([b4ffcd2](b4ffcd2))
* update base token rate on L1
([#2589](#2589))
([f84aaaf](f84aaaf))
* **zk_toolbox:** Add zk_supervisor run unit tests command
([#2610](#2610))
([fa866cd](fa866cd))
* **zk_toolbox:** Run formatters and linterrs
([#2675](#2675))
([caedd1c](caedd1c))


### Bug Fixes

* **contract-verifier:** Check for 0x in zkvyper output
([#2693](#2693))
([0d77588](0d77588))
* make set token multiplier optional
([#2696](#2696))
([16dff4f](16dff4f))
* **prover:** change bucket for RAM permutation witnesses
([#2672](#2672))
([8b4cbf4](8b4cbf4))
* use lower fair l2 gas price for cbt
([#2690](#2690))
([e1146fc](e1146fc))


### Performance Improvements

* **logs-bloom:** do not run heavy query if migration was completed
([#2680](#2680))
([f9ef00e](f9ef00e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants