feat(pli): add support for persistent config #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load environment variables from file. Defaults to reading them from `$ZKSYNC_HOME/etc/pliconfig`, overridable via the `PLI__CONFIG` variable. The parser is intentionally simple and permissive. It will simply not load anything from lines starting with `#` (considered a comment) or not containing an `=`. Everything else is loaded into the environment with everything to the left of `=` used as key and everything to the right of `=` used as value.
Oppen
force-pushed
the
feat/pli_config_cmd
branch
from
63f1b29 to
5b688db
Compare
Artemka374
approved these changes
May 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
🤖 I have created a release *beep* *boop* --- ## [14.4.0](prover-v14.3.0...prover-v14.4.0) (2024-05-30) ### Features * Make house keeper emit correct protocol version ([#2062](#2062)) ([a58a7e8](a58a7e8)) * **pli:** add support for persistent config ([#1907](#1907)) ([9d5631c](9d5631c)) * Protocol semantic version ([#2059](#2059)) ([3984dcf](3984dcf)) * **prover:** Add `prover_version` binary. ([#2089](#2089)) ([e1822f6](e1822f6)) ### Bug Fixes * fix null protocol version error ([#2094](#2094)) ([aab3a7f](aab3a7f)) * fix query for proof compressor metrics ([#2103](#2103)) ([d23d24e](d23d24e)) * **prover_dal:** fix `save_prover_protocol_version` query ([#2096](#2096)) ([d8dd1ae](d8dd1ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: perekopskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add configuration file and edition support to the prover CLI.
Why ❔
To avoid requiring manually passing all prover parameters every time.
Checklist
zk fmtandzk lint.zk spellcheck.