Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase the number of zksync health check retries #32

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What:
Increase the number of zksync health check retries in the docker compose config.

Why:
The current number of retries is insufficient to spin up the node and deploy all contracts. As a result, the node is considered unhealthy, and other projects can't use the docker --wait flag to wait for the node to become healthy, e.g:

docker compose up -d --build --wait --wait-timeout 2000

Locally, the process took just over 10 minutes, while the current setting is 10 * 20 = 200 sec. This issue has already been addressed in zk-chains-docker-compose.yml, but it was likely overlooked in docker-compose.yml. With this change, I'm setting the retries to 200, the same value already used in zk-chains-docker-compose.yml.

@vasyl-ivanchuk vasyl-ivanchuk requested a review from popzxc January 6, 2025 09:55
@popzxc popzxc merged commit 2ba19fa into main Jan 6, 2025
1 check passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the increase-number-of-healthcheck-retries branch January 6, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants