Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove wrong estimation in create for zksync transactions #864

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Jan 23, 2025

What 💻

  • Remove EIP1559 fee estimation for non-legacy transactions in zksync create flow of execution.
  • Fix timeout parameter that was being overwritten with the evm configuration
  • Add zk-gas-per-pubdata flag to specify the value in forge create

Why ✋

  • This was causing different deployments using forge script and forge create for zkchains.

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

…t parameter being retrieve wrong and gas per pubdata parameter
@Jrigada Jrigada requested a review from a team as a code owner January 23, 2025 20:54
elfedy
elfedy previously approved these changes Jan 24, 2025
@Jrigada Jrigada added this to the Release 0.0.5 milestone Jan 24, 2025
nbaztec
nbaztec previously approved these changes Jan 24, 2025
@Jrigada Jrigada merged commit cf0a88d into main Jan 24, 2025
23 checks passed
@Jrigada Jrigada deleted the jrigada-remove-eip-1599-estimation-create-and-add-missing-parameters branch January 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants