Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make ci work #308

Merged
merged 5 commits into from
Apr 5, 2024
Merged

fix: make ci work #308

merged 5 commits into from
Apr 5, 2024

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Apr 5, 2024 •
edited
Loading

Motivation

  • CI tests don't work as the async executor deadlocks indefinitely

Solution

  • Detect and handle sync and async contexts properly

@nbaztec nbaztec marked this pull request as ready for review April 5, 2024 17:20
@nbaztec nbaztec changed the base branch from dev to nish-fix-script-multi-deploy April 5, 2024 17:37
Jrigada
Jrigada approved these changes Apr 5, 2024
View reviewed changes
crates/zksync/compiler/src/zksolc/config.rs Outdated Show resolved Hide resolved
@nbaztec nbaztec merged commit 33c8e6f into nish-fix-script-multi-deploy Apr 5, 2024
3 checks passed
@nbaztec nbaztec deleted the nish-dbg-ci branch April 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jrigada Jrigada Jrigada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbaztec @Jrigada