fix: forge build, forge create, forge script and smoke tests #299
Conversation
nbaztec
force-pushed
the
nish-fix-build
branch
2 times, most recently
from
7b0a68e to
deac01b
Compare
| @@ -3,10 +3,10 @@ name: test | |||
| on: | |||
| push: | |||
| branches: | |||
| - foundry/main | |||
There was a problem hiding this comment.
nit: any reason why not both?
| TransactTo::Create(CreateScheme::Create2 { .. }) => CONTRACT_DEPLOYER_ADDRESS, | ||
| TransactTo::Create(CreateScheme::Create2 { .. }) => ( | ||
| CONTRACT_DEPLOYER_ADDRESS, | ||
| ZKVMData::new(db, &mut journaled_state).get_deploy_nonce(caller), |
There was a problem hiding this comment.
I think this deviates from hardhat - I tried searching the zksync hardhart plugin to understand what nonce they use for deployments, and it seems they always use the tx nonces.
The deployment nonce is handled internally by the system contracts.
After all a deployment is still a transaction.
Also I think we don't use this nonce everywhere for deployments, so it would be inconsistent (pretty sure I saw something in the files above that uses tx nonce for a create)
There was a problem hiding this comment.
Interesting, yeah the tx nonce is guaranteed to be greater than the deployment nonce. But it makes sense to pass the tx nonce, if the system contracts only ever use the deployment nonce internally. I'll investigate and update as needed.
| @@ -168,18 +174,18 @@ where | |||
| let caller = call.caller; | |||
| let calldata = encode_create_params(&call.scheme, contract.zk_bytecode_hash, constructor_input); | |||
| let factory_deps = vec![contract.zk_deployed_bytecode.clone()]; | |||
| let nonce = ZKVMData::new(db, journaled_state).get_tx_nonce(caller); | |||
| let nonce = ZKVMData::new(db, journaled_state).get_deploy_nonce(caller); | |||
Motivation
The following bugs were reported (and are fixed in this PR)
forge build --zksyncthis does not compile using zksolcforge create src/Counter.sol:Counter --rpc-url sepolia --chain 300 --private-key <PRIVATE-KEY> --zksync- this does deploy a contract correctly to zksync.Error (code: 3, message: Failed to serialize transaction: toAddressIsNull, data: None)
forge script script/Counter.s.sol:CounterScript --rpc-url=https://sepolia.era.zksync.dev/ --broadcast --private-key 0x... --zksyncError: no zk contract was found for 0x...
Solution
forge testfunctionality toforge build,forge createandforge script.vm.zkVm(true)cheatcode or passing the--zksyncflag.foundry_zksyncintofoundry_zksync_coreandfoundry_zksync_compilercrates to avoid circular dependecies.