Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #190

Merged

Conversation

eliashaeussler
Copy link
Contributor

@eliashaeussler eliashaeussler commented Nov 26, 2024

This PR adds support for PHP 8.4.

  • Used explicit nullable types
  • Added PHP 8.3 & 8.4 to test matrix
  • Fixed code style and static analysis workflows

@GenieTim GenieTim self-assigned this Nov 26, 2024
@GenieTim
Copy link
Collaborator

GenieTim commented Nov 26, 2024

Thank you for your contribution.

Do you mind adding PHP 8.3 & 8.4 to the test matrix (and removing whatever old version you consider appropriate)?

@eliashaeussler
Copy link
Contributor Author

@GenieTim I'll check the other workflows as well later. Converting to draft for the time being.

@eliashaeussler eliashaeussler marked this pull request as draft November 26, 2024 08:49
@eliashaeussler eliashaeussler force-pushed the fix/implicit-nullable-types branch from 86c1b1d to 6d29363 Compare November 26, 2024 09:05
@eliashaeussler eliashaeussler changed the title Avoid implicit nullable types (PHP 8.4 compatibility) Add support for PHP 8.4 Nov 26, 2024
@eliashaeussler eliashaeussler marked this pull request as ready for review November 26, 2024 09:28
@eliashaeussler eliashaeussler force-pushed the fix/implicit-nullable-types branch from 7aefb88 to ce90fe1 Compare November 26, 2024 09:29
@GenieTim GenieTim merged commit 4e546ee into matteosister:develop Nov 26, 2024
14 of 15 checks passed
@eliashaeussler eliashaeussler deleted the fix/implicit-nullable-types branch November 26, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants