Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section with tag, and no fields, causes section to display all fields #1

Closed
mattapperson opened this issue Sep 23, 2015 · 0 comments · Fixed by #6
Closed

Section with tag, and no fields, causes section to display all fields #1

mattapperson opened this issue Sep 23, 2015 · 0 comments · Fixed by #6

Comments

@mattapperson
Copy link
Owner

In this scenario:

- field1 tag=foo
- field2 tag=foo

<section tag=foo>
<section tag=bar>

Then both sections display all fields

but in this scenario:

- field1 tag=foo
- field2 tag=bar

<section tag=foo>
<section tag=bar>

everything works correctly
Georgette added a commit to Georgette/react-joi-forms that referenced this issue Nov 8, 2015
@Georgette
fixes issue mattapperson#1, if tag on component does not match a tag …
9de603f 
…in schema, render 0 fields
@Georgette Georgette mentioned this issue Nov 8, 2015
Merged
mattapperson pushed a commit that referenced this issue Nov 8, 2015
Merge pull request #6 from Georgette/master
b65631e 
This fixes #1, fixes #3 (If tag on a component does not match schema, render nothing  + link repo in package.json)
@mehiel mehiel mentioned this issue Apr 8, 2016
Open
mattapperson pushed a commit that referenced this issue Apr 4, 2017
@mehiel
Merge pull request #1 from costasmicha/feature/es6-refactoring
4342362 
ES6 refactoring fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mattapperson