chore: migrate to cli-table3

[DanielRuf]

No description provided.

[brandonocasey]

It would be really good to get this in to resolve the security issue, but I think it means dropping support for node <= 4, which would be a major version bump.

[DanielRuf]

Node.js 4 reached its EOL and will not get any security updates.

Do you want to support it? If yes, you can use the previous release of cli-table3.

[brandonocasey]

sorry for the confusion, I am not a maintainer here, I just wanted to make sure that everything has been discussed for this so that it can go in quickly

[mattallty]

Node.js 4 reached its EOL and will not get any security updates.

Do you want to support it? If yes, you can use the previous release of cli-table3.

You're right, we can drop support of it (so major version bump)

@DanielRuf thank you for the PR, could you please fix conflicts ?

[dannypaz]

@mattallty @DanielRuf let me know and I can make the fix w/ conflicts on another PR. We should update as cli-table2 is abandoned

[DanielRuf]

@DanielRuf thank you for the PR, could you please fix conflicts ?

Sorry, forgot to react. I'll rebase and resolve the conflicts (tomorrow morning).

[DanielRuf]

Sorry, forgot to react. I'll rebase and resolve the conflicts (tomorrow morning).

Done.

[dannypaz]

@mattallty is there anything we need to do RE: CHANGELOG or cutting a release?

[mattallty]

Just merged into master, if you guys could play with it, I will be happy to publish it on npm if no one suffers :) @dannypaz @DanielRuf @brandonocasey

[brandonocasey]

This appears to work for es-check as expected

[dannypaz]

@mattallty we've tested the version of caporal on 2 of our applications and everything looks good.

[dannypaz]

@mattallty let us know when the release is cut. The only issue that I came across was having some options filled out incorrectly, that caused some custom validations to fail.

// No longer works correctly with validation. The default value had changed from empty string to nil
.option('--market', 'Relevant market name', validations.isMarketName)

// This fixes the return value to the original functionality
.option('--market [marketname]', 'Relevant market name', validations.isMarketName)

Not sure if it is worth mentioning in the release notes. If you want me to dig up where this change was made in cli-table3, let me know.

[dannypaz]

@mattallty @DanielRuf Thank you both again for the help/work in getting this functionality in 🎊