Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output_trips.csv in MATSim 15 has empty main_mode #2779

Closed
mrieser opened this issue Sep 24, 2023 · 2 comments · Fixed by #2864
Closed

output_trips.csv in MATSim 15 has empty main_mode #2779

mrieser opened this issue Sep 24, 2023 · 2 comments · Fixed by #2864
Assignees
@mrieser
Labels
bug code sprint Possible issue(s) for the MATSim code sprint

Comments

@mrieser
Copy link
Contributor

mrieser commented Sep 24, 2023

In various models run with MATSim 15 I observed that the main_mode column in output_trips.csv is empty.
Should be fixed ;-)
@mrieser mrieser added bug code sprint Possible issue(s) for the MATSim code sprint labels Sep 24, 2023
@mrieser mrieser self-assigned this Sep 24, 2023
@mrieser mrieser changed the title output_trips.csv in MATsim 15 has empty main_mode output_trips.csv in MATSim 15 has empty main_mode Sep 24, 2023
@rakow
Copy link
Contributor

rakow commented Sep 26, 2023

I think this might already be fixed in #2680

@mrieser
Copy link
Contributor Author

mrieser commented Sep 26, 2023

Thanks for the link to the issue. I will have a look at it, and probably use the time then to write a test case so the main_mode won't be empty again in the future.

mrieser added a commit that referenced this issue Oct 13, 2023
@mrieser
add integration test to ensure main_mode in output_trips.csv is not e…
3ad035c 
…mpty

Closes #2779
@mrieser mrieser mentioned this issue Oct 13, 2023
Merged
@mrieser mrieser moved this to In Progress in CodeSprint 2023 Oct 13, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CodeSprint 2023 Oct 13, 2023
@syhwawa syhwawa mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrieser mrieser

Labels
bug code sprint Possible issue(s) for the MATSim code sprint
Projects
CodeSprint 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add IT to ensure main_mode in output_trips.csv is not empty matsim-org/matsim-libs
2 participants
@mrieser @rakow