Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_join test: Omit create event from state #1193

Merged
merged 1 commit into from
Feb 22, 2022
Merged

send_join test: Omit create event from state #1193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
send_join test: Omit create event from state 
As of MSC3706, omitting the create event from `auth_chain` is valid (because it
should also be in `state`). But it definitely *should* be there in `state`.
  • Loading branch information
@richvdh
richvdh committed Feb 21, 2022
commit b834787c18b72d61e88ad1af37a7b6c6ed9c6375
6 changes: 3 additions & 3 deletions tests/50federation/30room-join.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,14 +883,14 @@ sub assert_is_valid_pdu {
map { $_->[0] } @{ $event->{auth_events} }
);

# filter out the m.room.create event
@auth_chain = grep { $_->{type} ne 'm.room.create' } @auth_chain;
# filter out the m.room.create event from the state response
my @state_events = grep { $_->{type} ne 'm.room.create' } $room->current_state_events;

$req->respond_json(
# /v1/send_join has an extraneous [200, ...] wrapper (see MSC1802)
my $response = [ 200, {
auth_chain => \@auth_chain,
state => [ $room->current_state_events ],
state => \@state_events,
} ]
);

Expand Down