Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Pass back errors to the client when trying multiple federation destinations #9868

Merged
merged 9 commits into from
Apr 27, 2021
Merged

Pass back errors to the client when trying multiple federation destinations #9868

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e782e86
Do not manually raise SynapseError.
clokep Apr 21, 2021
990f5df
Clarify comments.
clokep Apr 22, 2021
46bec7e
Callbacks should raise the original HttpResponseException.
clokep Apr 22, 2021
da0b210
Consolidate some checks for unknown endpoints.
clokep Apr 22, 2021
12402ef
Apply similar logic to _do_send_invite.
clokep Apr 22, 2021
ce1e53b
Newsfragment
clokep Apr 22, 2021
24d3351
Merge remote-tracking branch 'origin/develop' into clokep/federation-…
clokep Apr 23, 2021
2a1e59e
Generate the SynapseError inside of _is_unknown_endpoint.
clokep Apr 23, 2021
2450803
Update docstring with error conditions.
clokep Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/9868.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a long-standing bug where errors from federation did not propagate to the client.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look sensible, but I'm not entirely sure which errors which were previously swallowed are now propagated correctly. Do you have any examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the rationale for the work is the 403 error in #9814 is now passed back to the client as a 403, instead of a 400.

Copy link
Member Author

@clokep clokep Apr 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably mention that this is partially tested by matrix-org/complement#99.