Give appropriate exit codes when synctl fails

changelog.d/5992.feature

@@ -0,0 +1 @@
+Give appropriate exit codes when syctl fails.

synctl

@@ -88,6 +88,7 @@ def start(configfile, daemonize=True):
             "error starting (exit code: %d); see above for logs" % e.returncode,
             colour=RED,
         )
+        raise
 
 
 def start_worker(app, configfile, worker_configfile):
@@ -102,6 +103,7 @@ def start_worker(app, configfile, worker_configfile):
             % (app, worker_configfile, e.returncode),
             colour=RED,
         )
+        raise
 
 
 def stop(pidfile, app):
@@ -292,11 +294,15 @@ def main():
             write("All processes exited; now restarting...")
 
     if action == "start" or action == "restart":
+        errors = 0
         if start_stop_synapse:
             # Check if synapse is already running
             if os.path.exists(pidfile) and pid_running(int(open(pidfile).read())):
                 abort("synapse.app.homeserver already running")
-            start(configfile, bool(options.daemonize))
+            try:
+                start(configfile, bool(options.daemonize))
+            except subprocess.CalledProcessError:
+                errors += 1
 
         for worker in workers:
             env = os.environ.copy()
@@ -307,12 +313,24 @@ def main():
             for cache_name, factor in iteritems(worker.cache_factors):
                 os.environ["SYNAPSE_CACHE_FACTOR_" + cache_name.upper()] = str(factor)
 
-            start_worker(worker.app, configfile, worker.configfile)
+            try:
+                start_worker(worker.app, configfile, worker.configfile)
+            except subprocess.CalledProcessError:
+                errors += 1
 
             # Reset env back to the original
             os.environ.clear()
             os.environ.update(env)
 
+        process_count = len(workers) + int(start_stop_synapse)
+
+        # If every process failed to start we exit with exit code 1. If a subset
+        # fails we exit with 4
+        if errors == process_count:
+            exit(1)
+        elif errors:
+            exit(4)
+
 
 if __name__ == "__main__":
     main()