This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Require ID and as_token be unique for ASs #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if appservice.id in seen_ids: | ||
| raise ConfigError( | ||
| "Cannot reuse ID across application services: %s" % ( | ||
| appservice.id, |
There was a problem hiding this comment.
Please log the file path which tried to use the ID, e.g. config_file.
|
LGTM |
Defaults ID to as_token if not specified. This will change when IDs are fully supported.
illicitonion
force-pushed
the
daniel/3
branch
from
319db83 to
2680043
Compare
illicitonion
added a commit
that referenced
this pull request
Jan 14, 2016
Require ID and as_token be unique for ASs Defaults ID to as_token if not specified. This will change when IDs are fully supported.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults ID to as_token if not specified. This will change
when IDs are fully supported.