Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

[DINSIC] Use internal-info for identity server #4681

Merged
merged 4 commits into from
Feb 28, 2019

Conversation

anoadragon453
Copy link
Member

Switches Synapse to use Sydent's new /internal-info API for information about 3PIDs when registering a new user.

Uses the new requires_invite field to check if a registration should be allowed.

Sydent PR: matrix-org/sydent#106

@anoadragon453 anoadragon453 requested a review from a team February 25, 2019 10:53
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise.

@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dinsic@2712a9e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dinsic    #4681   +/-   ##
=========================================
  Coverage          ?   72.07%           
=========================================
  Files             ?      335           
  Lines             ?    34019           
  Branches          ?        0           
=========================================
  Hits              ?    24518           
  Misses            ?     9501           
  Partials          ?        0
Impacted Files Coverage Δ
synapse/rest/client/v2_alpha/register.py 56.14% <ø> (ø)
synapse/rest/client/v2_alpha/account.py 59.01% <ø> (ø)
synapse/util/threepids.py 23.8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2712a9e...0a23bf4. Read the comment docs.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I guess.

@anoadragon453 anoadragon453 merged commit 3271742 into dinsic Feb 28, 2019
@anoadragon453 anoadragon453 deleted the dinsic_anoa/info_split branch April 9, 2019 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants