Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Don't build wheels for Python 3.7 #15917

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Don't build wheels for Python 3.7 #15917

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
123f2c7
Don't build wheels for CPython or PyPy 3.7
Jul 11, 2023
317da72
Update pyproject.toml comments
Jul 11, 2023
f303c93
Manually update the changelog
Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't build wheels for CPython or PyPy 3.7
  • Loading branch information
David Robertson committed Jul 11, 2023
commit 123f2c7d7817d2203afaa3b7e3aad134a10c916a
9 changes: 8 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,14 @@ build-backend = "poetry.core.masonry.api"

[tool.cibuildwheel]
# Skip unsupported platforms (by us or by Rust).
skip = "cp36* *-musllinux_i686 pp*aarch64 *-musllinux_aarch64"
# See https://cibuildwheel.readthedocs.io/en/stable/options/#build-skip for the list of build targets.
# We skip:
# - CPython 3.6 and 3.7: EOLed
# - PyPy 3.7: we only support Python 3.8+
# - musllinux i686: TODO why?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have always been this way without reason given: #12595 (comment)

# - PyPy on Aarch64: TODO why?
# - musllinux on aarch64: TODO why?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems related to speed of build according to #14259.

ISTR that aarch64 builds are slow as hell because they don't run natively but inside qemu, and the non CPython versions are a lot less useful to people.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too slow: #14259

skip = "cp36* cp37* pp37* *-musllinux_i686 pp*aarch64 *-musllinux_aarch64"

# We need a rust compiler
before-all = "curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y --profile minimal"
Expand Down