Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add basic read/write lock #15782

Merged
merged 9 commits into from
Jul 5, 2023
Merged

Add basic read/write lock #15782

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f7eef00
Move lock methods into `Lock` class.
erikjohnston Jun 14, 2023
2d7c0a3
Add read/write lock
erikjohnston Jun 14, 2023
00ad613
Newsfile
erikjohnston Jun 14, 2023
f77e472
Fix port db script
erikjohnston Jun 15, 2023
96cc8bd
Apply suggestions from code review
erikjohnston Jun 23, 2023
b5b3c5e
We don't need to upsert
erikjohnston Jun 23, 2023
67cdfa9
Review comments
erikjohnston Jun 23, 2023
1354d91
Rewrap
erikjohnston Jun 23, 2023
690f4a3
Merge remote-tracking branch 'origin/develop' into erikj/read_write_lock
erikjohnston Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Newsfile
  • Loading branch information
@erikjohnston
erikjohnston committed Jun 15, 2023
commit 00ad613692d25130f5cfcfb80166859a6fc2464b
1 change: 1 addition & 0 deletions changelog.d/15782.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add read/write style cross-worker locks.
Copy link
Contributor

@MadLittleMods MadLittleMods Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good 👍

I haven't fully mind-melded into the code around the constraints to see something wrong (I did look at everything though) but the tests look robust enough to catch any errant behavior. If you want me to fully understand this, feel free to poke again specifically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the constraints a closer look. I think they make sense.

Kept trying to think if we could do it with one table but couldn't figure anything out that gets us that same read xor write behavior.