This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add membership event to inital batch of events slated for batch persisting during room creation #14711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #13800 and is part of the work to speed up initial room creation. This PR adds the membership event to the initial batch of events created for batch persisting when a room is created.
Formerly, the code called the
update_membership
function to create a membership event. This code now does relevant checks and transformations (which I pulled fromupdate_membership
) on the creator join profile, etc and then creates the membership event locally and adds it to the batch of events for batch persisting. As a reviewer convince yourself that all the relevant checks and transformations for a join/membership event have been applied in the new path.