Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Clarify (room_id, event_id) global uniqueness #13701

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Clarify (room_id, event_id) global uniqueness #13701

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25fa1c4
Clarify `(room_id, event_id)` uniqueness
MadLittleMods Sep 1, 2022
14c1dd5
Add changelog
MadLittleMods Sep 1, 2022
4fb453f
Merge branch 'develop' into madlittlemods/event-id-room-id-uniqueness
MadLittleMods Sep 1, 2022
5dd24f3
No apostrophe needed
MadLittleMods Sep 2, 2022
893d4c5
Put the uniqueness in the right context
MadLittleMods Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No apostrophe needed 
Co-authored-by: reivilibre <[email protected]>
  • Loading branch information
@MadLittleMods @reivilibre
MadLittleMods and reivilibre authored Sep 2, 2022
commit 5dd24f34bdb4c557ab0433678b9540e4183206b6
2 changes: 1 addition & 1 deletion docs/development/database_schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ same `event_id` (in the same or different rooms). After room version `3`, that
can only happen with a hash collision, which we basically hope will never
happen.

There are several places in Synapse and even Matrix API's like [`GET
There are several places in Synapse and even Matrix APIs like [`GET
/_matrix/federation/v1/event/{eventId}`](https://spec.matrix.org/v1.1/server-server-api/#get_matrixfederationv1eventeventid)
where we assume that event IDs are globally unique.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems rather sad considering they are very much not and it's not very hard to cause a conflict :/

Copy link
Contributor Author

@MadLittleMods MadLittleMods Sep 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can hope for MSC2848 🙌


Expand Down