Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Experimental support for MSC3772 #12740

Merged
merged 18 commits into from
May 24, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds a XXX comment.
  • Loading branch information
clokep committed May 18, 2022
commit 330a7355af088e88abb53e591d9968926be8037c
4 changes: 4 additions & 0 deletions synapse/push/push_rule_evaluator.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ def matches(
):
return self._relation_match(condition, user_id)
else:
# XXX This looks incorrect -- we have reached an unknown condition
# kind and are unconditionally returning that it matches. Note
# that it seems possible to provide a condition to the /pushrules
# endpoint with an unknown kind, see _rule_tuple_from_request_object.
return True

def _event_match(self, condition: dict, user_id: str) -> bool:
Expand Down