This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Check that gc method is available before using in synapse/app/_base
#11816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
approved these changes
Jan 24, 2022
callahad
reviewed
Jan 24, 2022
Co-authored-by: Dan Callahan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar check was removed in #11683. The check determined whether the program was being run on Python 3.7 before using a garbage collection method and thus was deemed redundant in this comment: #11683 (review), so I removed it. However, it was pointed out here: #11683 (comment) that not all implementations of Python have that API so I have restored a version of the removed check in this new PR.