Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Correctly register shutdown handler for presence workers #11518

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Correctly register shutdown handler for presence workers #11518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
888925b
Correctly register shutdown handler for presence workers
Dec 6, 2021
43f95ed
Create 11518.bugfix
Dec 6, 2021
6a4582b
Merge branch 'develop' into dmr/fix-presence-shutdown
Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11518.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a regression in Synapse 1.48.0 where presence workers would not clear their presence updates over replication on shutdown.
2 changes: 1 addition & 1 deletion synapse/handlers/presence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ def __init__(self, hs: "HomeServer"):
self._on_shutdown,
)

def _on_shutdown(self) -> None:
async def _on_shutdown(self) -> None:
if self._presence_enabled:
self.hs.get_tcp_replication().send_command(
ClearUserSyncsCommand(self.instance_id)
Expand Down