Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Remove the deprecated BaseHandler. #11005

Merged
merged 21 commits into from
Oct 8, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove BaseHandler from FederationHandler.
  • Loading branch information
clokep committed Oct 6, 2021
commit 822ce1c80b0590ce65900e4a41292c9d3bcfce63
2 changes: 0 additions & 2 deletions synapse/handlers/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ def __init__(self, hs: "HomeServer"):

self.server_name = hs.hostname

self.event_builder_factory = hs.get_event_builder_factory()

async def ratelimit(
self,
requester: Requester,
Expand Down
6 changes: 2 additions & 4 deletions synapse/handlers/federation.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
from synapse.events.snapshot import EventContext
from synapse.events.validator import EventValidator
from synapse.federation.federation_client import InvalidResponseError
from synapse.handlers._base import BaseHandler
from synapse.http.servlet import assert_params_in_dict
from synapse.logging.context import (
make_deferred_yieldable,
Expand All @@ -78,15 +77,13 @@
logger = logging.getLogger(__name__)


class FederationHandler(BaseHandler):
class FederationHandler:
"""Handles general incoming federation requests

Incoming events are *not* handled here, for which see FederationEventHandler.
"""

def __init__(self, hs: "HomeServer"):
super().__init__(hs)

self.hs = hs

self.store = hs.get_datastore()
Expand All @@ -99,6 +96,7 @@ def __init__(self, hs: "HomeServer"):
self.is_mine_id = hs.is_mine_id
self.spam_checker = hs.get_spam_checker()
self.event_creation_handler = hs.get_event_creation_handler()
self.event_builder_factory = hs.get_event_builder_factory()
self._event_auth_handler = hs.get_event_auth_handler()
self._server_notices_mxid = hs.config.servernotices.server_notices_mxid
self.config = hs.config
Expand Down