Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

get_forgotten_rooms_for_user cache is not invalidated when rejoining a room #13262

Closed
squahtx opened this issue Jul 12, 2022 · 0 comments · Fixed by #15815
Closed

get_forgotten_rooms_for_user cache is not invalidated when rejoining a room #13262

squahtx opened this issue Jul 12, 2022 · 0 comments · Fixed by #15815
Labels
A-Join Joining a room (there is another label for federated joins) S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@squahtx
Copy link
Contributor

squahtx commented Jul 12, 2022

The get_forgotten_rooms_for_user cache is only invalidated when a user /forgets a room, and not when a user re-joins a room.

I think this means we may exclude previously-forgotten rooms from an initial /sync, even if the user is now joined to them.

@squahtx squahtx added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 12, 2022
@MadLittleMods MadLittleMods added the A-Join Joining a room (there is another label for federated joins) label Apr 25, 2023
nico-famedly added a commit to famedly/synapse that referenced this issue Jun 21, 2023
If you leave a room and forget it, then rejoin it, the room would be
missing from the next initial sync.

fixes matrix-org#13262

Signed-off-by: Nicolas Werner <[email protected]>
nico-famedly added a commit to famedly/synapse that referenced this issue Jun 21, 2023
If you leave a room and forget it, then rejoin it, the room would be
missing from the next initial sync.

fixes matrix-org#13262
erikjohnston pushed a commit that referenced this issue Jun 21, 2023
If you leave a room and forget it, then rejoin it, the room would be
missing from the next initial sync.

fixes #13262

Signed-off-by: Nicolas Werner <[email protected]>
jcgruenhage pushed a commit to famedly/synapse that referenced this issue Sep 4, 2023
If you leave a room and forget it, then rejoin it, the room would be
missing from the next initial sync.

fixes matrix-org#13262

Signed-off-by: Nicolas Werner <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Join Joining a room (there is another label for federated joins) S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants