Change logging of puppeted requests to better differentiate users (#1…

…0779) This used to be a comma and got accidentally changed to a period in #9654, but a pipe character is more easier to parse visually.
matrix-org · Sep 8, 2021 · 66d72b7 · 66d72b7
1 parent 580a15e
commit 66d72b7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/10779.misc b/changelog.d/10779.misc
@@ -0,0 +1 @@
+Change the format of authenticated users in logs when a user is being puppeted by and admin user.
diff --git a/synapse/http/site.py b/synapse/http/site.py
@@ -384,7 +384,7 @@ def _finished_processing(self):
         # authenticated (e.g. and admin is puppetting a user) then we log both.
         requester, authenticated_entity = self.get_authenticated_entity()
         if authenticated_entity:
-            requester = f"{authenticated_entity}.{requester}"
+            requester = f"{authenticated_entity}|{requester}"
 
         self.site.access_logger.log(
             log_level,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Change the format of authenticated users in logs when a user is being puppeted by and admin user.