Send device list updates out to servers in partially joined rooms

Use the provided list of servers in the room from the `/send_join` response, since we will not know which users are in the room. This isn't sufficient to ensure that all remote servers receive the right device list updates, since the `/send_join` response may be inaccurate or we may calculate the membership state of new users in the room incorrectly. Signed-off-by: Sean Quah <[email protected]>
matrix-org · Sep 22, 2022 · 2ae6fb9 · 2ae6fb9
1 parent 3681eb4
commit 2ae6fb9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/synapse/handlers/device.py b/synapse/handlers/device.py
@@ -688,11 +688,15 @@ async def _handle_new_device_update_async(self) -> None:
                     # Ignore any users that aren't ours
                     if self.hs.is_mine_id(user_id):
                         hosts = set(
-                            await self._storage_controllers.state.get_current_hosts_in_room(
+                            await self._storage_controllers.state.get_current_hosts_in_room_or_partial_state_approximation(
                                 room_id
                             )
                         )
                         hosts.discard(self.server_name)
+                        # For rooms with partial state, `hosts` is merely an
+                        # approximation. When we transition to a full state room, we
+                        # will have to send out device list updates to any servers we
+                        # missed.
 
                     # Check if we've already sent this update to some hosts
                     if current_stream_id == stream_id: