-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenSSL security level 1 in Docker container #262
Conversation
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
CI for this repo's been broken for a few days now. |
# Work around 'CA MD too weak' errors when using APNs developer certificates, | ||
# by reducing the OpenSSL security level to 1 (from 2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe link to the issue? and add a comment that in the long-term, supporting JWK tokens would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the JWT tokens not what we already support when we speak of 'token-based authentication'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh. If we already support that, I would encourage people to use it rather than making this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, yes, I think it is. Can we go back to the people on #260 and ask them to try it?
This appears to be actions/setup-python#260 I thought adding the right metadata to |
Closing in favor of asking people to use JWT-based auth. If the original reporter responds to #260 (comment) with a comment indicating that this is not possible, then we can re-open and merge this PR. |
Fixes #260.