Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSL security level 1 in Docker container #262

Closed
wants to merge 4 commits into from

Conversation

reivilibre
Copy link
Contributor

Fixes #260.

@reivilibre reivilibre requested a review from a team as a code owner October 28, 2021 15:46
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
@squahtx
Copy link
Contributor

squahtx commented Oct 28, 2021

CI for this repo's been broken for a few days now.
pip 21.3 (released 2021-10-11) does not like our setup.py, but pip 21.3.1 (released 2021-10-22) is ok.
I'm hoping GitHub Actions picks up the new pip release soon.

Comment on lines +31 to +32
# Work around 'CA MD too weak' errors when using APNs developer certificates,
# by reducing the OpenSSL security level to 1 (from 2).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe link to the issue? and add a comment that in the long-term, supporting JWK tokens would be better?

Copy link
Contributor Author

@reivilibre reivilibre Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the JWT tokens not what we already support when we speak of 'token-based authentication'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh. If we already support that, I would encourage people to use it rather than making this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, yes, I think it is. Can we go back to the people on #260 and ask them to try it?

@reivilibre
Copy link
Contributor Author

CI for this repo's been broken for a few days now. pip 21.3 (released 2021-10-11) does not like our setup.py, but pip 21.3.1 (released 2021-10-22) is ok. I'm hoping GitHub Actions picks up the new pip release soon.

This appears to be actions/setup-python#260
which links to pypa/pip#10573.

I thought adding the right metadata to pyproject.toml might appease it, but it didn't work.

@callahad
Copy link
Contributor

callahad commented Nov 4, 2021

Closing in favor of asking people to use JWT-based auth. If the original reporter responds to #260 (comment) with a comment indicating that this is not possible, then we can re-open and merge this PR.

@callahad callahad closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA_MD_TOO_WEAK for dev APNS certificate
4 participants