Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improved static type checking in setup.py #221

Merged
merged 4 commits into from
Apr 23, 2021
+5 −2
Merged

Add improved static type checking in setup.py #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffd4456
Add improved static type checking in setup.py
kibablu Apr 15, 2021
7c68238
Add changelog for #221
kibablu Apr 21, 2021
06d55e4
Fix improved static type checking setup.py
kibablu Apr 22, 2021
608ac96
Fix error in mypy type annotation in setup.py
kibablu Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/221.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Document on improving static type checking using mypy. Contributed by Omar Mohamed.
6 changes: 4 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import os
import os.path
from os import PathLike
from typing import Union

from setuptools import find_packages, setup

Expand All @@ -25,7 +27,7 @@
# Used for the long_description. It's nice, because now 1) we have a top level
# README file and 2) it's easier to type in the README file than to put a raw
# string in below ...
def read(fname):
def read(fname: Union[str, "PathLike[str]"]) -> str:
return open(os.path.join(os.path.dirname(__file__), fname)).read()


Expand Down