Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reconnection in DB pool #179

Merged
merged 1 commit into from
Mar 18, 2021
+8 −1
Merged

Enable reconnection in DB pool #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/179.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug where Sygnal would not recover after losing connection to the database.
8 changes: 7 additions & 1 deletion sygnal/sygnal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,15 @@ def __init__(self, config, custom_reactor, tracer=opentracing.tracer):

if db_name == "psycopg2":
logger.info("Using postgresql database")

# By default enable `cp_reconnect`. We need to fiddle with db_args in case
# someone has explicitly set `cp_reconnect`.
db_args = dict(config["database"].get("args", {}))
db_args.setdefault("cp_reconnect", True)

self.database_engine = "postgresql"
self.database = ConnectionPool(
"psycopg2", cp_reactor=self.reactor, **config["database"].get("args")
"psycopg2", cp_reactor=self.reactor, **db_args
)
elif db_name == "sqlite3":
logger.info("Using sqlite database")
Expand Down