Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PusherData is undocumented in the Push Gateway API #910

Closed
dkasak opened this issue Oct 20, 2021 · 2 comments · Fixed by #1968
Closed

PusherData is undocumented in the Push Gateway API #910

dkasak opened this issue Oct 20, 2021 · 2 comments · Fixed by #1968
Labels
A-Push clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@dkasak
Copy link
Member

dkasak commented Oct 20, 2021 •
edited
Loading

Link to problem area:

https://spec.matrix.org/unstable/push-gateway-api/

Issue

PusherData is mentioned in https://spec.matrix.org/unstable/push-gateway-api/, but the format is not spelled out anywhere. event_id_only and format are mentioned, but do not link to anywhere. It is spelled out in the C2S API, though, if that's supposed to be the same thing.

The Push Gateway API should either spell out what PusherData is or link to an appropriate section elsewhere.
@dkasak dkasak added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit A-Push labels Oct 20, 2021
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
Johennes added a commit to Johennes/matrix-spec that referenced this issue Oct 11, 2024
@Johennes
Document schema of PusherData in push gateway API
8d786e5 
Fixes: matrix-org#910
Signed-off-by: Johannes Marbach <[email protected]>
Johennes added a commit to Johennes/matrix-spec that referenced this issue Oct 11, 2024
@Johennes
Document schema of PusherData in push gateway API
694c49d 
Fixes: matrix-org#910
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes mentioned this issue Oct 11, 2024
Merged
3 tasks
@richvdh
Copy link
Member

richvdh commented Oct 29, 2024

PushData is mentioned in spec.matrix.org/unstable/push-gateway-api, but the format is not spelled out anywhere.

I guess this meant to say PusherData.

@dkasak
Copy link
Member Author

dkasak commented Oct 29, 2024

Ugh, yes. The title says as much but I typoed in the body. I'll edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Push clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document schema of PusherData in push gateway API Johennes/matrix-spec
2 participants
@dkasak @richvdh