Clarify the case of HTML-only topics and transition logic #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
merged commit a6b1555
into
matrix-org:johannes/rich-room-topics
1 check passed
turt2live
added a commit
that referenced
this pull request
Feb 24, 2025
* Add rich room topic MSC Signed-off-by: Johannes Marbach <[email protected]> * Rename to reflect propper MSC number * Fix typo * Explain why m.topic is kept separate from m.message * Use json5 for formatting code snippet Co-authored-by: Travis Ralston <[email protected]> * Remove unneeded unstable room version * Adapt to latest version of MSC1767 * Add paragraph about preventing formatting abuse * Introduce wrapping m.topic content block (#4111) * Clarify the case of HTML-only topics and transition logic (#4112) * Clarify and simplify transition logic * Clarify the case of HTML-only topics * Make it more explicit that m.topic replaces m.room.topic without deprecation (#4181) * Remove line-based formatting logic and limit length of topics (#4182) * Update MSC3765: Rich text in room topics (#4215) Updates MSC from feedback, * Accept suggestion Co-authored-by: Johannes Marbach <[email protected]> * Clarify length / display limits. Co-authored-by: Johannes Marbach <[email protected]> * Apply clarifications from author Co-authored-by: Johannes Marbach <[email protected]> * Make MSC3765 independent of extensible events and new room versions (#4240) * Apply suggestions from code review * Update proposals/3765-rich-room-topics.md Co-authored-by: Johannes Marbach <[email protected]> * Properly explain why the m.topic content block is needed (#4251) * Apply suggestions from code review Co-authored-by: Johannes Marbach <[email protected]> --------- Signed-off-by: Johannes Marbach <[email protected]> Co-authored-by: Travis Ralston <[email protected]> Co-authored-by: David Baker <[email protected]> Co-authored-by: Patrick Cloke <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address https://github.com/matrix-org/matrix-spec-proposals/pull/3765/files#r1068933707 and https://github.com/matrix-org/matrix-spec-proposals/pull/3765/files#r1068935153 while I don't have push access to the branch.