-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oidc): Match the proper error type for invalid refresh token #4767
Conversation
Since we do not use mas-oidc-client anymore, the error to match has changed. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4767 +/- ##
==========================================
+ Coverage 86.29% 86.36% +0.07%
==========================================
Files 291 291
Lines 34291 34306 +15
==========================================
+ Hits 29590 29627 +37
+ Misses 4701 4679 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of suggestions for the tests. Thanks for catching and fixing this so quickly.
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
This was forgotten in #4761. Since we do not use mas-oidc-client anymore, the error to match has changed.
The second commit adds tests that would have catched the regression.