Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oidc): Match the proper error type for invalid refresh token #4767

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Mar 6, 2025

This was forgotten in #4761. Since we do not use mas-oidc-client anymore, the error to match has changed.

The second commit adds tests that would have catched the regression.

zecakeh added 2 commits March 6, 2025 17:24
Since we do not use mas-oidc-client anymore, the error to match has changed.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner March 6, 2025 17:37
@zecakeh zecakeh requested review from poljar and removed request for a team March 6, 2025 17:37
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.36%. Comparing base (daad6d6) to head (82aaeb8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/test_utils/mocks/mod.rs 76.47% 4 Missing ⚠️
crates/matrix-sdk/src/client/futures.rs 60.00% 2 Missing ⚠️
crates/matrix-sdk/src/test_utils/mocks/oauth.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4767      +/-   ##
==========================================
+ Coverage   86.29%   86.36%   +0.07%     
==========================================
  Files         291      291              
  Lines       34291    34306      +15     
==========================================
+ Hits        29590    29627      +37     
+ Misses       4701     4679      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions for the tests. Thanks for catching and fixing this so quickly.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from poljar March 7, 2025 11:40
Signed-off-by: Kévin Commaille <[email protected]>
@poljar poljar enabled auto-merge (rebase) March 7, 2025 11:59
@poljar poljar merged commit 18f5668 into matrix-org:main Mar 7, 2025
43 checks passed
@zecakeh zecakeh deleted the refresh-token-error branch March 7, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants