Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid enormous type name + related refactoring #447

Merged
merged 5 commits into from
Dec 28, 2021
Merged

Avoid enormous type name + related refactoring #447

merged 5 commits into from
Dec 28, 2021

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Dec 27, 2021

Got nerd-sniped into looking for & fixing a huge type name by #414 (comment).

@jplatte
Copy link
Collaborator Author

jplatte commented Dec 27, 2021

The original type name contained the tuple 21 times, and the tuple itself had a type name length of 566 bytes. I think the new type name will still be a bit long (matrix_sdk_crypto::session_manager::group_sessions::GroupSessionManager::encrypt_session_for::EncryptResult, if I got that right, is 107 bytes) but the reduction in the overall type name of that drop_in_place instantiation should still be pretty good: (566 - 107) * 21 = 9639, almost cutting the length down by two thirds.

@poljar poljar merged commit d92d777 into matrix-org:main Dec 28, 2021
@jplatte jplatte deleted the huge-type-name branch December 28, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants