feat(sdk): Remove the SlidingSyncRoom::required_state method
#3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
changed the title
SlidingSyncRoom::required_state method
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
==========================================
+ Coverage 83.73% 83.75% +0.01%
==========================================
Files 224 224
Lines 23510 23508 -2
==========================================
+ Hits 19685 19688 +3
+ Misses 3825 3820 -5 ☔ View full report in Codecov by Sentry. |
This patch removes a useless and not used (in the Matrix Rust SDK, along with the FFI bindings) method: `SlidingSyncRoom::required_state`.
Hywan
force-pushed
the
fix-sdk-sliding-sync-room-required-state
branch
from
5c0cab3 to
44e438b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a useless and not used (in the Matrix Rust SDK, along with the FFI bindings) method:
SlidingSyncRoom::required_state.This is based on #3080. Please see only the last commit.
SlidingSyncRoomtech debt #3079