Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery support: Or how to tame secret storage and backups #2842

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Nov 11, 2023

This PR implements a Recovery API. This API or subsystem attempts to unify the backup and secret storage support into a single and simplified API.

This Recovery API is also what Element X uses for their backup and secret storage support.

@poljar poljar self-assigned this Nov 20, 2023
Base automatically changed from poljar/backup-pr to main November 24, 2023 17:16
@poljar poljar force-pushed the poljar/recovery-pr branch from 68faa18 to 2324f39 Compare November 24, 2023 17:27
@poljar poljar marked this pull request as ready for review November 24, 2023 17:27
@poljar poljar requested a review from a team as a code owner November 24, 2023 17:27
@poljar poljar requested review from jplatte and removed request for a team November 24, 2023 17:27
@poljar
Copy link
Contributor Author

poljar commented Nov 24, 2023

Not actually ready for review, but want to get the CI going.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (05f0106) 82.64% compared to head (1b492ae) 82.65%.
Report is 1 commits behind head on main.

❗ Current head 1b492ae differs from pull request most recent head 0937934. Consider uploading reports for the commit 0937934 to get more accurate results

Files Patch % Lines
...ates/matrix-sdk/src/encryption/recovery/futures.rs 76.25% 19 Missing ⚠️
crates/matrix-sdk/src/encryption/recovery/mod.rs 84.33% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2842    +/-   ##
========================================
  Coverage   82.64%   82.65%            
========================================
  Files         216      219     +3     
  Lines       22183    22354   +171     
========================================
+ Hits        18333    18476   +143     
- Misses       3850     3878    +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar force-pushed the poljar/recovery-pr branch 3 times, most recently from de10621 to d48dc79 Compare November 28, 2023 11:17
@poljar
Copy link
Contributor Author

poljar commented Nov 28, 2023

This is now ready for review. cc @jplatte

@poljar poljar requested a review from dkasak November 28, 2023 11:44
@poljar poljar force-pushed the poljar/recovery-pr branch from 604a22a to 1b492ae Compare November 28, 2023 15:11
@poljar poljar force-pushed the poljar/recovery-pr branch from 1b492ae to 0937934 Compare November 29, 2023 10:07
@poljar poljar merged commit 94c4e68 into main Nov 30, 2023
@poljar poljar deleted the poljar/recovery-pr branch November 30, 2023 14:12
@bertybuttface
Copy link

Is there an example of how to use this recovery API?

@Hywan
Copy link
Member

Hywan commented Dec 14, 2023

You can check the documentation which contains examples, https://matrix-org.github.io/matrix-rust-sdk/matrix_sdk/encryption/recovery/index.html.

@bertybuttface
Copy link

bertybuttface commented Dec 14, 2023

~~Thanks for replying but is this not different?

This PR seems to be adding a new convenience API which that example does not.~~

Scratch that, there are examples in the docs just not in the code repository examples folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants