Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: Add _blocking versions of async methods #2577

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Sep 19, 2023

To work around Kotlin bugs in UniFFI.

@jplatte jplatte requested a review from a team as a code owner September 19, 2023 09:27
@jplatte jplatte requested review from Hywan and removed request for a team September 19, 2023 09:27
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e80aae) 77.84% compared to head (dfa72f4) 77.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2577   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         182      182           
  Lines       19569    19569           
=======================================
  Hits        15233    15233           
  Misses       4336     4336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte force-pushed the jplatte/ffi-blocking branch from 17c9219 to 537f37c Compare September 19, 2023 09:50
@jplatte jplatte force-pushed the jplatte/ffi-blocking branch from 537f37c to dfa72f4 Compare September 19, 2023 09:53
@jplatte jplatte changed the title ffi: Add _blocking versions of async methods on Room ffi: Add _blocking versions of async methods# Sep 19, 2023
@jplatte jplatte changed the title ffi: Add _blocking versions of async methods# ffi: Add _blocking versions of async methods Sep 19, 2023
@jplatte jplatte enabled auto-merge (rebase) September 19, 2023 09:58
@jplatte jplatte merged commit 13c9b0f into main Sep 19, 2023
@jplatte jplatte deleted the jplatte/ffi-blocking branch September 19, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants