Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Show room broadcast when ending a recording #9841

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Show room broadcast when ending a recording #9841

merged 4 commits into from
Jan 2, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Dec 28, 2022 •
edited by github-actions bot
Loading

If you stop a broadcast recording in a room with a live broadcast, show the live broadcast.

closes element-hq/element-web#24072

PSF-1805

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 28, 2022
@weeman1337 weeman1337 marked this pull request as ready for review December 29, 2022 08:09
@weeman1337 weeman1337 requested a review from a team as a code owner December 29, 2022 08:09
germain-gg
germain-gg approved these changes Dec 31, 2022
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For some reason the TS strict checks are unhappy with you, but it seems unrelated to your changes!

@weeman1337 weeman1337 enabled auto-merge (squash) January 2, 2023 07:55
@weeman1337 weeman1337 merged commit 91e078d into develop Jan 2, 2023
@weeman1337 weeman1337 deleted the weeman1337/show-broadcast-after-end-recording branch January 2, 2023 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@artcodespace artcodespace Awaiting requested review from artcodespace artcodespace is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the live PIP listener widget when the potential PIP recorder widget is closed
2 participants
@weeman1337 @germain-gg