This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Use new thread labs feature name #9748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
T-Defect
andybalaam
approved these changes
Dec 13, 2022
t3chguy
approved these changes
Dec 13, 2022
turt2live
reviewed
Dec 13, 2022
| @@ -66,7 +66,7 @@ export function doesRoomHaveUnreadMessages(room: Room): boolean { | |||
| // despite the name of the method :(( | |||
| const readUpToId = room.getEventReadUpTo(myUserId!); | |||
|
|
|||
| if (!SettingsStore.getValue("feature_thread")) { | |||
| if (!SettingsStore.getValue("feature_threadstable")) { | |||
There was a problem hiding this comment.
please also update labs/betas.md in element-web :)
There was a problem hiding this comment.
That file is in a different repo so can't be part of this PR anyway
There was a problem hiding this comment.
yup, just mentioning it as a step to complete
|
@matrix-org/element-web-app-team the |
|
git is super angry about this for some reason on the i18n check - for safety, I've remade the PR at #9749 and will merge that one (considering approval can't be transferred easily) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Tests written for new code (and old code if feasible)Here's what your changelog entry will look like:
🐛 Bug Fixes