Remove "Add Space" button in RoomListHeader when user cannot createSpaces

[estellecomment]

Problem description :
When using ComponentVilisbility to disable UIComponent.CreateSpaces, buttons for creating spaces should be hidden.

But there is one that is still displayed, in RoomListHeader, for creating a subspace :

This is incoherent with SpaceContextMenu, where you can also create a subspace, which does hide the button (as expected) :

Expected : the button for adding subspaces is hidden everywhere.
Obtained : one button for adding subspaces is hidden (in SpaceContextMenu), the other is shown (in RoomListHeader).
Proposed fix : hide the button for adding subspaces in RoomListHeader. Reuse similar code as SpaceContextMenu to harmonize.

Notes for reviewers : in order to see the fix in element-web, you need to use ComponentVisibility to get shouldShowComponent(UIComponent.CreateSpaces) == false.
Example PR to do this, in a fork of element-web : https://github.com/tchapgouv/element-web/pull/2/files

Signed-off-by: Estelle Comment [email protected]

---

Here's what your changelog entry will look like:

✨ Features

• Remove "Add Space" button in RoomListHeader when user cannot createSpaces (#9002). Contributed by @estellecomment.

[estellecomment]

@weeman1337 who follows this issue 👋

[weeman1337]

It would be good to have a test covering the changes.

There is already a RoomListHeader test that can be extended: https://github.com/matrix-org/matrix-react-sdk/blob/develop/test/components/views/rooms/RoomListHeader-test.tsx

If you need help on this just send me a message.

[estellecomment]

@weeman1337 Done with tests, ready for re-review !

[robintown]

Thanks for following through with the tests, this looks really good! My comments are mostly just about types, and places where we have a more modern way of doing things.

[robintown]

The loading-test suite appears to be failing

[mcalinghee]

The loading-test suite appears to be failing

This is now fixed

[robintown]

Great, could you please merge develop to restart CI?

[robintown]

Also, for future reference, please don't force push to a branch after it's been reviewed, as that makes it more difficult to tell what changes were reviewed and which weren't.

[robintown]

We're still trying to get our CI to work but everything looks good to go in theory

[robintown]

Our CI is currently unable to test this change, as it's matching with a branch of the same name in the Tchap element-web fork which disables space creation entirely. @estellecomment or @mcalinghee, you'll need to rename either this branch or the element-web branch in your forks, so that they no longer get matched.

[weeman1337]

Thanks for updating everything 👍 I will trigger the builds again.

[mcalinghee]

Our CI is currently unable to test this change, as it's matching with a branch of the same name in the Tchap element-web fork which disables space creation entirely. @estellecomment or @mcalinghee, you'll need to rename either this branch or the element-web branch in your forks, so that they no longer get matched.

Thanks a lot, this is now done

[robintown]

One of our CI checks wasn't able to run because of this PR being a month old, so I've opened a new PR with the same changes.