Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fixed a minor typo #8041

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fixed a minor typo #8041

merged 1 commit into from
Mar 11, 2022

Conversation

ankur12-1610
Copy link
Contributor

@ankur12-1610 ankur12-1610 commented Mar 11, 2022

Fixes: #21396


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8041--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@ankur12-1610 ankur12-1610 requested a review from a team as a code owner March 11, 2022 18:38
@ankur12-1610
Copy link
Contributor Author

My easiest and quickest bug fix till now :P

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #8041 (771f54f) into develop (7508fd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8041   +/-   ##
========================================
  Coverage    26.79%   26.79%           
========================================
  Files          865      865           
  Lines        51972    51972           
  Branches     13165    13165           
========================================
  Hits         13926    13926           
  Misses       38046    38046           
Impacted Files Coverage Δ
src/Unread.ts 27.58% <ø> (ø)

@SimonBrandner SimonBrandner added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 11, 2022
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff

(thanks!)

@turt2live turt2live merged commit c0fec42 into matrix-org:develop Mar 11, 2022
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankur12-1610
Copy link
Contributor Author

ankur12-1610 commented Mar 11, 2022

Iff is not a typo.
https://en.m.wikipedia.org/wiki/If_and_only_if#:~:text=In%20logic%20and%20related%20fields,true%20or%20both%20are%20false.

Oh! no,it didn't clicked me at all🥲

Really sorry for it, will a PR which reverts this change.

@SimonBrandner
Copy link
Contributor

Iff is not a typo.
en.m.wikipedia.org/wiki/If_and_only_if#:~:text=In%20logic%20and%20related%20fields,true%20or%20both%20are%20false.

Oh! no,it didn't clicked me at allsmiling_face_with_tear

Really sorry for it, will a PR which reverts this change.

I would suggest making it if and if only to be more explicit...

@t3chguy
Copy link
Member

t3chguy commented Mar 11, 2022

Don't worry about it, it doesn't change the meaning in this case, just for future ref iff is fairly common in maths and programming

@turt2live
Copy link
Member

well, that explains why WebStorm didn't yell at me about it. Thanks for the link :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor typo in matrix-react-sdk/src/Unread.ts
4 participants